Many thanks for the excellent fixes put in. Can I trouble you to look at a couple of niggles please?
-
Clicking on Git - Files produces a 500 error when using a standalone Git instance (http://localhost:8622/applications/1/git/browse).
-
Clicking on the first Commit link ID produces a 500 error when using a standalone Git instance.
-
When adding Git on a per application level, the first time that you create a connection, with new credentials, the connection adds successfully but won't sync. It shows as "not synced". Digging into the error logs shows "System.InvalidCastException: Unable to cast object of type 'Inedo.Extensions.Credentials.UsernamePasswordCredentials' to type 'Inedo.Extensibility.Git.GitServiceCredentials'." At this point the Git browse menu appears in the header navigation bar but cannot be used (all 500 errors).
To get around this, go back and add it again but select the credentials created in the previous step rather than typing them this time. The repository syncs and adds successfully. If you are trying to reproduce this on a system that has successfully added this repo with credentials before, ensure you remove it from the Global Services and Credentials screen or the bug will not appear (http://localhost:8622/secure-credentials)
- When trying to add a new credential for Git standalone with the same username as a previous entry, without specifying a new credential name under the advanced options, you receive a SQL FK exception rather than a user message "the credential with that username is already added". - "2627
14
1Credentials_CreateOrUpdateCredential
22`Violation of UNIQUE KEY constraint 'UQ__Credentials'. Cannot insert duplicate key in object 'dbo.Credentials'. The duplicate key value is (<NULL>, Git-test1, <NULL>, <NULL>). Transaction count after EXECUTE indicates a mismatching number of BEGIN and COMMIT statements. Previous count = 1, current count = 0."
Please pass on my thanks to all involved in this which makes a real difference - the ability to have a Pipeline linked in to standalone Git with building on commit is amazing, using the same agent as Otter is just the icing on the cake.