|OTTER] Status filter not working for "any error"

philippe.camelio_3885

Hi,
Just to report a small bug and and an observation
The bug :
In the server section, the status filter is not working for "any error"

The observation:
The filter list

is not consistant with existing status

Otter last docker version
Best regards
PhilippeC.

atripp

Thanks for the bug report @philippe-camelio_3885 !

I logged as OT-508 , and we'll target it an upcoming maintenance release :)

atripp

Hi @philippe-camelio_3885 ,

I looked at this one more closely, and it's behaving as expected.

"any error" means AgentError, CollectionError, or RemediationError. There are many other statuses, and the page doesn't filter on all of them (including NoRoles or Unknown).

The status scenario is complex

If you are curious to the logic

string getStatus()
{
    if (!server.Active_Indicator)
        return Disabled;
    
    if (server.HasNullAgent())
        return Unknown;
    if (!server.HasLocalAgent())
    {
        if (server.AgentStatus_Code == Domains.AgentStatusCode.Error)
            return AgentError;
        if (server.AgentStatus_Code == Domains.AgentStatusCode.Updating)
            return AgentUpdating;
        if (server.AgentStatus_Code == Domains.AgentStatusCode.Unknown)
            return Unknown;
    }

    if (server.RoutineConfigurationUsage_Code == Domains.ServerRoutineConfigurationUsage.None)
        return NoCollection;
    if (!server.HasRoles_Indicator)
        return NoRoles;
    if (server.LatestCollection_Execution_Id == null)
        return Unknown;
    if (server.LatestCollection_ExecutionRunState_Code == Domains.ExecutionRunState.Executing)
        return Collecting;
    if (server.LatestCollection_ExecutionStatus_Code == Domains.ExecutionStatus.Error)
        return CollectionError;

    if (server.LatestRemediation_ExecutionRunState_Code == Domains.ExecutionRunState.Executing)
        return Collecting;
    if (server.PendingRemediation_Indicator)
        return PendingRemediation;
    if (server.LatestRemediation_ExecutionStatus_Code == Domains.ExecutionStatus.Error)
        return RemediationError;

    if (server.ConfigurationState_Code == Domains.ConfigurationState.Current)
        return Current;

    if (server.ConfigurationState_Code == Domains.ConfigurationState.Drifted)
        return Drifted;

    return Unknown;
}

Of course it could be improved, but perhaps another day

Best,
Alana

philippe.camelio_3885

@atripp
Thanks for the update