[OTTER 3.0] Adding dependencies in role break server access

philippe.camelio_3885

Hi
I found a bug in otter 3.0

Create a server SVRTEST
Create role ROLE1
Create role ROLE2 with dependancy to ROLE1
Assign role 2 to server

Access to server is broken

If dependancy is removed, access to server is OK

Error Message

URL: https://otter3.test.lan/servers/details?serverName=SVRTEST
Referrer: https://otter3.test.lan/roles/role?serverRoleName=role2
User: (unknown)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.90 Safari/537.36
Stack trace: à Inedo.Otter.WebApplication.Pages.Servers.ConflatedStatus.<.ctor>g__getStatus|66_0(<>c__DisplayClass66_0& )
à Inedo.Otter.WebApplication.Pages.Servers.ServerDetailsPage.CreateChildControls()
à Inedo.Otter.WebApplication.Pages.OtterSimplePageBase.<InitializeAsync>d__7.MoveNext()
--- Fin de la trace de la pile à partir de l'emplacement précédent au niveau duquel l'exception a été levée ---
à System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
à System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
à Inedo.Web.PageFree.SimplePageBase.<ExecutePageLifeCycleAsync>d__55.MoveNext()
--- Fin de la trace de la pile à partir de l'emplacement précédent au niveau duquel l'exception a été levée ---
à System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
à System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
à Inedo.Web.PageFree.SimplePageBase.<ProcessRequestAsync>d__54.MoveNext()
--- Fin de la trace de la pile à partir de l'emplacement précédent au niveau duquel l'exception a été levée ---
à System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
à System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
à System.Web.TaskAsyncHelper.EndTask(IAsyncResult ar)
à Inedo.Web.Handlers.AsyncHandlerWrapper.EndProcessRequest(IAsyncResult result)
à System.Web.HttpApplication.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute()
à System.Web.HttpApplication.ExecuteStepImpl(IExecutionStep step)
à System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)

stevedennis

Confirmed! Thanks for the report; there is a regression with displaying the status of dependent roles.

I did a very quick code patch so the page wouldn't crash (don't display dependent roles on that page), but the real fix will come via OT-412 - we'll target it for the upcoming maintenance release, but this one might be a bit tricky b/c that particular code is a bit messy. We'll get it fixed.

philippe.camelio_3885

Thank you