upack cli --version and --manifest

msimkin_1572

version: upack 3.1.1.0

When I attempt to execute the upack pack command:

upack pack folder/ --version=1.0.1 --manifest=manifest.json --tragetDirectory=packagefolder/

I receive the error:

Invalid upack.json: missing or invalid version

I would like to override the version from the command line. I have tried manifest.json files that omit the version tag or set the version tag to null.

When using a manifest file, can the version be provided on the command line or must it be in the file?

Also, I did try placing the version tag with a value in the manifest file, however, the value in the file is used, not the value on the command line.

Thanks

atripp

Hello,

This is by design; looking over the code, it seems the command says "If metadata file is provided, value will be ignored." I can't answer why that's the design/behavior.

You're welcome to submit a pull request to update the behavior. Here is the relevant code:
https://github.com/Inedo/upack/blob/master/src/upack/Pack.cs

My main concern is, what if someone is relying on the value being ignored , either accidently or intentionally. I don't have a great idea for how to address that concern... though my first thought is to deprecate the manifest argument and rename to manifestFile.

So it's not a trivial change, but you're welcome to give it a shot. It's unlikely we will implement this ourselves anytime soon, as we have a lot of other feature requests on ProGet that take priority, and UPack gets a decent number of pull requests from the community.

Cheers,
Alana

msimkin_1572

Hi @atripp:

Thank you for the clarification.

The documentation on this page https://docs.inedo.com/docs/upack-tools-and-libraries-upack-cli should be updated to clarify that you need to either provide the command line arguments or the manifest file, but not both.

-marc

stevedennis

Hi @msimkin_1572 , good idea! I just added a small note at the bottom, where we specify manifest. To be honest, I didn't even know that was possible