Deadlock with the FailoverDetectionRunner

[Antoine]

Hi we are getting a lot of this error in the diagnostic center searched here but I've found nothing of the sort. Do any of you have any idea has to what could be the cause of those errors ? We are using Proget in High Avability mode with Active Directory(new)

Category : FailoverDetectionRunner

Message : Unhandled exception: 12051356IndexingServers_SetUpdated60`Transaction (Process ID 91) was deadlocked on lock resources with another process and has been chosen as the deadlock victim. Rerun the transaction.

Details : System.Data.SqlClient.SqlException (0x80131904): 12051356IndexingServers_SetUpdated60Transaction (Process ID 91) was deadlocked on lock resources with another process and has been chosen as the deadlock victim. Rerun the transaction. at System.Data.SqlClient.SqlCommand.<>c.<ExecuteDbDataReaderAsync>b__174_0(Task1 result)
at System.Threading.Tasks.ContinuationResultTaskFromResultTask2.InnerInvoke() at System.Threading.Tasks.Task.Execute() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Inedo.Data.DatabaseContext.DbResult.<CreateAsync>d__10.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Inedo.Data.DatabaseContext.<ExecuteInternalAsync>d__33.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Inedo.Data.DatabaseContext.<ExecuteNonQueryAsync>d__31.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Inedo.Data.DatabaseContext.<ExecuteScalarAsync>d__301.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Inedo.ProGet.Service.FailoverDetectionRunner.<RunAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Inedo.TaskRunner.<RunInternalAsync>d__43.MoveNext()
ClientConnectionId:71ce329c-75d7-4073-acfc-1f28a203de39
Error Number:50000,State:42,Class:13

Product: ProGet
Version: 5.1.5

[Greg]

Hi Antoine,

How frequently is this happening? That stored procedure is executed as part of the failover detection logic. Due to the way the associated table is accessed, I could see deadlocks happening sometimes, and we should fix the code to handle that better. (I've logged PG-1361 to do this).

[Antoine]

Hi Greg, it happened two times in the last month.

[Greg]

We've included a fix for this in ProGet 5.1.0, which will likely be released tomorrow.

Thanks!