Proget 5.2.13 Upgrade Issue with Docker

[sbmatt]

I just upgraded Proget from 5.2.12 to 5.2.13 in Docker using the official image https://hub.docker.com/r/inedo/proget

The upgraded container would not start.

docker logs proget

ProGet version is 5.2.13.20.
Attempting to use shared configuration for ProGet.
Shared configuration file loaded from /usr/share/Inedo/SharedConfig/ProGet.config.
No encryption key is configured. Credentials will be stored in plain text.
Current DB schema version is unknown.
System.ArgumentException: Keyword not supported: data source
Parameter name: keyword
  at Npgsql.NpgsqlConnectionStringBuilder.GetProperty (System.String keyword) [0x0001f] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at Npgsql.NpgsqlConnectionStringBuilder.set_Item (System.String keyword, System.Object value) [0x0000c] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at System.Data.Common.DbConnectionStringBuilder.set_ConnectionString (System.String value) [0x00084] in <f3b036cdf45644d58864dfe09bb31bd4>:0 
  at Npgsql.NpgsqlConnectionStringBuilder..ctor (System.String connectionString) [0x00017] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at Npgsql.NpgsqlConnection+<>c__DisplayClass33_0.<set_ConnectionString>b__0 (System.String s) [0x00000] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at System.Collections.Concurrent.ConcurrentDictionary`2[TKey,TValue].GetOrAdd (TKey key, System.Func`2[T,TResult] valueFactory) [0x00034] in <285579f54af44a2ca048dad6be20e190>:0 
  at Npgsql.NpgsqlConnection.set_ConnectionString (System.String value) [0x00020] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at Npgsql.NpgsqlConnection..ctor (System.String connectionString) [0x0000c] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at (wrapper remoting-invoke-with-check) Npgsql.NpgsqlConnection..ctor(string)
  at Inedo.BuildMasterExtensions.PostgreSql.PostgreSqlDatabaseProvider.CreateConnectionAsync () [0x00018] in <12af21c1942f493583c13ed13025eb5e>:0 
  at Inedo.LazyAsync`1[T].GetValueAsync () [0x0018a] in <ee7a5f9ece0745948bcfc1883d4013bb>:0 
  at Inedo.BuildMasterExtensions.PostgreSql.PostgreSqlDatabaseProvider.ExecuteScalarAsync (System.String query, System.Threading.CancellationToken cancellationToken) [0x0008a] in <12af21c1942f493583c13ed13025eb5e>:0 
  at Inedo.BuildMasterExtensions.PostgreSql.PostgreSqlDatabaseProvider.GetStateAsync (System.Threading.CancellationToken cancellationToken) [0x00084] in <12af21c1942f493583c13ed13025eb5e>:0 
  at Inedo.BuildMaster.DatabaseConnections.DatabaseUpdaterProgram`1[TConnection].UpdateAsync () [0x000bc] in <6d489682b1204963b8bdae24f00b0185>:0 
  at Inedo.BuildMaster.DatabaseConnections.DatabaseUpdaterProgram`1[TConnection].RunCommand (System.String commandName) [0x00091] in <6d489682b1204963b8bdae24f00b0185>:0

[gdivis]

Hi,

I've tried to reproduce this in a few different ways, but it seems to work for me. What are the exact arguments you're passing to docker run?

[gdivis]

Just a quick update- I realized our upgrade instructions are wrong. If you're using SQL Server, you'll need to specify the database type and the connection string with the docker run command: (see the updated instructions here: https://docs.inedo.com/docs/proget/installation/installation-guide/linux-docker)

[sbmatt]

Hi, thanks very much for your help.

I'm actually using docker-compose but I seem to have the correct details. Relevant section:

proget:
    # https://hub.docker.com/r/inedo/proget/tags
    image: inedo/proget:5.2.12
    container_name: proget
    restart: always
    environment:
        - PROGET_DB_TYPE=SqlServer
        - "PROGET_DATABASE=Data Source=sqlserver;Initial Catalog=ProGet;User ID=sa;Password=mypassword;"
    volumes:
        - /etc/localtime:/etc/localtime:ro
        - /mnt/proget/packages:/var/proget/packages
        - /mnt/proget/extensions:/var/proget/extensions
    ports:
        - "5002:80"

The above (with 5.2.12) works perfectly, but if I change the version to 5.2.13 the new container fails to start with the errors above.

Any ideas?

[deepab]

I have come across the same issue.

[gdivis]

We've now reproduced this, and it turns out there's a regression in 5.2.13 with how config files are read which determine whether to use SQL Server or postgres. We have implemented a fix as PG-1614, which will be included in ProGet 5.2.14 (scheduled for release on Friday, October 18).

For now, I'd recommend just reverting to 5.2.12 until the next version is available.

Thanks to all who reported this!

[deepab]

@gdivis Thank you!

[sbmatt]

@gdivis Awesome! Thanks!