sbmatt

sbmatt

I just upgraded Proget from 5.2.12 to 5.2.13 in Docker using the official image https://hub.docker.com/r/inedo/proget

The upgraded container would not start.

docker logs proget

ProGet version is 5.2.13.20.
Attempting to use shared configuration for ProGet.
Shared configuration file loaded from /usr/share/Inedo/SharedConfig/ProGet.config.
No encryption key is configured. Credentials will be stored in plain text.
Current DB schema version is unknown.
System.ArgumentException: Keyword not supported: data source
Parameter name: keyword
  at Npgsql.NpgsqlConnectionStringBuilder.GetProperty (System.String keyword) [0x0001f] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at Npgsql.NpgsqlConnectionStringBuilder.set_Item (System.String keyword, System.Object value) [0x0000c] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at System.Data.Common.DbConnectionStringBuilder.set_ConnectionString (System.String value) [0x00084] in <f3b036cdf45644d58864dfe09bb31bd4>:0 
  at Npgsql.NpgsqlConnectionStringBuilder..ctor (System.String connectionString) [0x00017] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at Npgsql.NpgsqlConnection+<>c__DisplayClass33_0.<set_ConnectionString>b__0 (System.String s) [0x00000] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at System.Collections.Concurrent.ConcurrentDictionary`2[TKey,TValue].GetOrAdd (TKey key, System.Func`2[T,TResult] valueFactory) [0x00034] in <285579f54af44a2ca048dad6be20e190>:0 
  at Npgsql.NpgsqlConnection.set_ConnectionString (System.String value) [0x00020] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at Npgsql.NpgsqlConnection..ctor (System.String connectionString) [0x0000c] in <e79cdc94ec2744279f279146dae83ac3>:0 
  at (wrapper remoting-invoke-with-check) Npgsql.NpgsqlConnection..ctor(string)
  at Inedo.BuildMasterExtensions.PostgreSql.PostgreSqlDatabaseProvider.CreateConnectionAsync () [0x00018] in <12af21c1942f493583c13ed13025eb5e>:0 
  at Inedo.LazyAsync`1[T].GetValueAsync () [0x0018a] in <ee7a5f9ece0745948bcfc1883d4013bb>:0 
  at Inedo.BuildMasterExtensions.PostgreSql.PostgreSqlDatabaseProvider.ExecuteScalarAsync (System.String query, System.Threading.CancellationToken cancellationToken) [0x0008a] in <12af21c1942f493583c13ed13025eb5e>:0 
  at Inedo.BuildMasterExtensions.PostgreSql.PostgreSqlDatabaseProvider.GetStateAsync (System.Threading.CancellationToken cancellationToken) [0x00084] in <12af21c1942f493583c13ed13025eb5e>:0 
  at Inedo.BuildMaster.DatabaseConnections.DatabaseUpdaterProgram`1[TConnection].UpdateAsync () [0x000bc] in <6d489682b1204963b8bdae24f00b0185>:0 
  at Inedo.BuildMaster.DatabaseConnections.DatabaseUpdaterProgram`1[TConnection].RunCommand (System.String commandName) [0x00091] in <6d489682b1204963b8bdae24f00b0185>:0

sbmatt

Hi, thanks very much for your help.

I'm actually using docker-compose but I seem to have the correct details. Relevant section:

proget:
    # https://hub.docker.com/r/inedo/proget/tags
    image: inedo/proget:5.2.12
    container_name: proget
    restart: always
    environment:
        - PROGET_DB_TYPE=SqlServer
        - "PROGET_DATABASE=Data Source=sqlserver;Initial Catalog=ProGet;User ID=sa;Password=mypassword;"
    volumes:
        - /etc/localtime:/etc/localtime:ro
        - /mnt/proget/packages:/var/proget/packages
        - /mnt/proget/extensions:/var/proget/extensions
    ports:
        - "5002:80"

The above (with 5.2.12) works perfectly, but if I change the version to 5.2.13 the new container fails to start with the errors above.

Any ideas?

sbmatt

Hi, I'm sorry I don't seem to have got a notification email when you replied, so I only just saw this.

I just tried 5.2.29 and it works perfectly.

Many thanks!

sbmatt

Hey, on upgrade from 5.2.27 to 5.2.28 I get a SqlException. Stack trace displayed on the web interface is below.

Downgrading back to 5.2.27 resolves the issue.

I'm using the latest Sql Server image: mcr.microsoft.com/mssql/server:2019-CU4-ubuntu-16.04

Many thanks

at System.Data.ProviderBase.DbConnectionPool.TryGetConnection (System.Data.Common.DbConnection owningObject, System.UInt32 waitForMultipleObjectsTimeout, System.Boolean allowCreate, System.Boolean onlyOneCheckConnection, System.Data.Common.DbConnectionOptions userOptions, System.Data.ProviderBase.DbConnectionInternal& connection) [0x00085] in <0864334e7e474248b37afca9b637daa9>:0
at System.Data.ProviderBase.DbConnectionPool.TryGetConnection (System.Data.Common.DbConnection owningObject, System.Threading.Tasks.TaskCompletionSource1[TResult] retry, System.Data.Common.DbConnectionOptions userOptions, System.Data.ProviderBase.DbConnectionInternal& connection) [0x00026] in <0864334e7e474248b37afca9b637daa9>:0 at System.Data.ProviderBase.DbConnectionFactory.TryGetConnection (System.Data.Common.DbConnection owningConnection, System.Threading.Tasks.TaskCompletionSource1[TResult] retry, System.Data.Common.DbConnectionOptions userOptions, System.Data.ProviderBase.DbConnectionInternal oldConnection, System.Data.ProviderBase.DbConnectionInternal& connection) [0x0021d] in <0864334e7e474248b37afca9b637daa9>:0
at System.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal (System.Data.Common.DbConnection outerConnection, System.Data.ProviderBase.DbConnectionFactory connectionFactory, System.Threading.Tasks.TaskCompletionSource1[TResult] retry, System.Data.Common.DbConnectionOptions userOptions) [0x00036] in <0864334e7e474248b37afca9b637daa9>:0 at System.Data.ProviderBase.DbConnectionClosed.TryOpenConnection (System.Data.Common.DbConnection outerConnection, System.Data.ProviderBase.DbConnectionFactory connectionFactory, System.Threading.Tasks.TaskCompletionSource1[TResult] retry, System.Data.Common.DbConnectionOptions userOptions) [0x00000] in <0864334e7e474248b37afca9b637daa9>:0
at System.Data.SqlClient.SqlConnection.TryOpen (System.Threading.Tasks.TaskCompletionSource1[TResult] retry) [0x0005d] in <0864334e7e474248b37afca9b637daa9>:0 at System.Data.SqlClient.SqlConnection.Open () [0x0003b] in <0864334e7e474248b37afca9b637daa9>:0 at Inedo.Data.SqlServerDatabaseContext.CreateConnection () [0x0006c] in <ee7a5f9ece0745948bcfc1883d4013bb>:0 at Inedo.ProGet.Data.ProGetDatabaseContext+WrappedSqlContext.Inedo.ProGet.Data.ProGetDatabaseContext.IWrappedContext.CreateConnection () [0x00000] in <3aef087dca1647b88f882788c4da0641>:0 at Inedo.ProGet.Data.ProGetDatabaseContext.CreateConnection () [0x00000] in <3aef087dca1647b88f882788c4da0641>:0 at Inedo.Data.DatabaseContext.ExecuteInternal (System.String storedProcName, Inedo.Data.GenericDbParameter[] parameters) [0x00064] in <ee7a5f9ece0745948bcfc1883d4013bb>:0 at Inedo.Data.DatabaseContext+<>c__DisplayClass29_01[TRow].<EnumerateTable>b__0 () [0x00000] in <ee7a5f9ece0745948bcfc1883d4013bb>:0
at Inedo.Data.StrongDataReader+<Read>d__61[TRow].MoveNext () [0x0003e] in <ee7a5f9ece0745948bcfc1883d4013bb>:0 at System.Collections.Generic.List1[T].AddEnumerable (System.Collections.Generic.IEnumerable1[T] enumerable) [0x00059] in <c453bf849bb84e719dbec0475e99db95>:0 at System.Collections.Generic.List1[T]..ctor (System.Collections.Generic.IEnumerable1[T] collection) [0x00062] in <c453bf849bb84e719dbec0475e99db95>:0 at System.Linq.Enumerable.ToList[TSource] (System.Collections.Generic.IEnumerable1[T] source) [0x00018] in <22384ee444974b39bb55b725de39c721>:0
at Inedo.ProGet.Data.DB.Configuration_GetConfiguration () [0x0000b] in <3aef087dca1647b88f882788c4da0641>:0
at Inedo.ProGet.InternalConfig.ReadConfigValues () [0x00000] in <3aef087dca1647b88f882788c4da0641>:0
at Inedo.LazyCached1[T].GetValue () [0x00019] in <ee7a5f9ece0745948bcfc1883d4013bb>:0 at Inedo.LazyCached1[T].get_Value () [0x00000] in <ee7a5f9ece0745948bcfc1883d4013bb>:0
at Inedo.ProGet.ProGetConfig1[TConfig].ReadFullyQualifiedValue (System.String scopedKey) [0x00000] in <3aef087dca1647b88f882788c4da0641>:0 at Inedo.ProGet.ProGetConfig1[TConfig].ReadValue (System.String key) [0x00006] in <3aef087dca1647b88f882788c4da0641>:0
at Inedo.ProGet.ProGetConfig+Extensions.get_ExtensionsPath () [0x00000] in <3aef087dca1647b88f882788c4da0641>:0
at Inedo.ProGet.WebApplication.ProGetHttpModule.BeginFirstRequestAsync (System.Web.HttpApplication app) [0x00061] in <9eb6fd46cc654188be94814164c2eb3e>:0
at Inedo.Web.InedoHttpModule.HandleBeginFirstRequestInternal (System.Web.HttpApplication app) [0x000e5] in <552cf13df3c1427b87b305d8f051c033>:0
at Inedo.Web.InedoHttpModule.ProcessEnd (System.IAsyncResult ar) [0x00017] in <552cf13df3c1427b87b305d8f051c033>:0
at System.Web.HttpApplication.async_callback_completed_cb (System.IAsyncResult ar) [0x0000d] in <b4f0b153c02f4f0588d3f7549d75281b>:0

sbmatt

@gdivis Awesome! Thanks!

sbmatt