BuildMaster Bugs

[ForgotMyUsername]

I found the following bugs using the latest version of BuildMaster:

1. Checkout-Code operation using Generic Git repository with recurse submodules option set to True but where no submodules exist causes an exception (Exception of type system.exception) on attempt to build.

2. Every minute an exception appears in error logs when using a generic git repository using stored credentials. details as follows-category: automatic builds, level: error, message: an exception occured while checking resources xxxx at global:git-******* details. Unable to cast object of type inedo.extensions.credentials.usernamepasswordcredentials to type inedo.extensibility.git.gitservicecredentials at inedo.extensibility.git.gitrepository.getremotebranchesasync

3. Clone application fails when trying to clone application using generic git repository. Error fails on the getting list of security tasks in the system. Exception is system.argument.nullexceptiom. value cannot be null. Parameter key.

4. When using the include file path of * not **, in create artifact, folders are created (but no files - as expected). Should the folders still still be created?

5. Left over fail remnants on a failed build sometime result in the error "folder exists for xxxx.git" in the temp folder. This means when attempting a build it fails because the folder already exists (and doesn't attempt to overwrite it). Deleting the folder manually allows a build to continue.

[dean-houston]

Hi @ForgotMyUsername,

Thanks for sharing all of these; we'll try to reproduce/investigate and fix some of these soon.

[1] and [3] seem pretty easy to test/reproduce.

For [2], that's definitely strange. I assume, that's a generic Git repository? I thought we had fixed that, but I wanted to confirm before investigating further.

For [4], that's a good question. The behavior kind of makes sense from a technical standpoint, but it doesn't make a lot of sense from a user perspective. I don't know if we want to change it outside of a major version. Someonme might be accidently relying on it.

For [5], we haven't seen that before. Any details you can share would be helpful, such as the OtterScript plan you're using and so on. Is this the execution temp folder, etc? We have several things to work-around random git corruption, but I want to see where this is before explolring more.

[ForgotMyUsername]

@dean-houston said in BuildMaster Bugs:

ption, but I want to see where this is before explolring more.

Thanks Dean, yes for 2, defitnley a generic Git Repostitory.

4 - I understand! No problem if not! No real impact on me, maybe just perhaps a documentation update?

5 - I think I caused this by copying another .GIT repo into the existing repo with the same name. Therefore the repo was not what it was expecting?

[atripp]

Hi @ForgotMyUsername ,

1. Checkout-Code operation using Generic Git repository with recurse submodules...

I can't reproduce this, but I can see how that issue might occur. Your repository must have a GitLink entry in the target tree (i.e. folder you're checking out), but there's no corresponding reference entry in the .gitmodules file. I've updated that to be a warning., and just pushed the Git 2.2.3 extension.

It will be included in the next maintenance release of BuildMaster, or you can download/upgrade now.

2. Every minute an exception appears...

Nice find; this will be fixed in next maintenance release (2022.10) via BM-3844

3. Clone application fails when trying to clone application using generic git repository...

I believe this is related to importing "releaseless-builds", and this may be fixed in 2022.9 via an internal commit (i.e. one we didn't log an issue for). Clone does an export then import. If that doesn't fix it, please export the application and provide it to us, so we can inspect the file for issues.

Regarding [5], can you send logs? The scenario you describe (existing repo with the same name) is already tested and handled, but there's likely something that's missing.