uploading debian package with plurl still required distrubtion

manuel.riezebosch_8638

Working:

http://localhost:8624/api/packages/my-debian/upload?purl=pkg%3Adeb%2Fnano%409.0-1%3Farch%3Di386%26distro%3Dwtf&distribution=x

Not working:

http://localhost:8624/api/packages/my-debian/upload?purl=pkg%3Adeb%2Fnano%409.0-1%3Farch%3Damd64%26distro%3Dwtf
Write-Error: Upload failed for pkg:deb/nano@9.0-1?arch=amd64&distro=wtf Distribution must be specified when adding a Debian package.

So the actual distribution doesn't matter since it's already part of the purl but upload fails when omitted.

dean-houston

Hi @manuel-riezebosch_8638 ,

It looks like the HTTP Endpoint documentation for the pgutil packages upload command was not accurate. A purl is not used here. I've updated the docs as follows...

To upload a package, simply PUT to the URL with a feed name, an appropriate API Key and a package in either ZIP, JAR or TAR format depending on the value of the Content-Type header.

PUT /api/packages/«feed-name»/upload[/«package-file-name»]

The «package-file-name» part of the URL is only required for the PyPI and RPM feed types, while Debian feeds will require a distribution argument and an optional component. See the corresponding upload package method on ProGetClient.cs for the most accurate and up-to-date pgutil and HTTP endpoint argument mapping.

Hope that helps!

-- Dean

manuel.riezebosch_8638

@dean-houston from my tests it did look like the information was correctly retrieved from the purl, the distro of the uploaded package matched the distro from the purl and not from the specific query string parameter. I also used it for uploading other packages, but most of them have the metadata inside the package anyway.

dean-houston

@manuel.riezebosch_8638 the purl argument was never actually read, so you could have really put anything in there :)

It was just one of those docs error; many other api endpoints will use a purl argument

And you're right... all the other package types have metadata inside the package, so that's what's read. Some require a file name, but Debian is an outlier in that it requires a distribution argument as well.