ProGet 24.0.23: Maven (new) Feed no longer accepts our (in 24.0.22 accepted) pom files.

[hammel_7023]

We are building and "deploying" our Maven jars to ProGet with mvn clean package deploy.

I upgraded ProGet to 24.0.23 today and suddenly our package pom files are no longer being accepted. Both new and old builds (rerun of previously working package deployments) get an InternalServerError on the deploy step. Below you can find the error log seen in the Diagnostic Center. Rollback to 24.0.22 solved the issue for now ... no code changes needed on our side.

Seeing https://issues.inedo.com/issue/PG-2859 in the changelog makes me wonder if there was something introduced there? It does not seem there was support for invalid files added, but removed? Also I would not know where our pom files could be invalid ... maven and every other tool used does not seem to think so. Would have been nice to have a proper error describing what ProGet thinks is invalid - if possible.

To clarify: I am talking about the docker tags 24.0.23 and 24.0.22 .... In the UI those are shown as 2024.24 (Build 15) and 2024.22 (Build 5).

An error occurred processing a PUT request to https://proget.xxx.local/maven2/xxx/xx/xxx/xxxx/1.0/xxxxxx-1.0.pom: File is not a valid pom file.

Inedo.ProGet.InvalidPackageException: File is not a valid pom file.
 ---> System.ObjectDisposedException: Cannot access a closed Stream.
   at System.IO.MemoryStream.set_Position(Int64 value)
   at Inedo.ProGet.Feeds.Maven2.PomFile.Inedo.ProGet.Feeds.IPackageManifest<Inedo.ProGet.Feeds.Maven2.PomFile>.ReadAndParseMetadataFromPackage(Stream packageStream, PackageInstallContext context) in C:\Users\builds\AppData\Local\Temp\InedoAgent\BuildMaster\192.168.44.60\Temp\_E519417\Src\ProGetCoreEx\Feeds\Maven2\PomFile.cs:line 218
   --- End of inner exception stack trace ---
   at Inedo.ProGet.Feeds.Maven2.PomFile.Inedo.ProGet.Feeds.IPackageManifest<Inedo.ProGet.Feeds.Maven2.PomFile>.ReadAndParseMetadataFromPackage(Stream packageStream, PackageInstallContext context) in C:\Users\builds\AppData\Local\Temp\InedoAgent\BuildMaster\192.168.44.60\Temp\_E519417\Src\ProGetCoreEx\Feeds\Maven2\PomFile.cs:line 223
   at Inedo.ProGet.Feeds.StandardCanonicalPackageFeed`5.ReadPackageMetadata(Stream packageStream, PackageInstallContext context) in C:\Users\builds\AppData\Local\Temp\InedoAgent\BuildMaster\192.168.44.60\Temp\_E519417\Src\ProGetCoreEx\Feeds\StandardCanonicalPackageFeed.cs:line 415
   at Inedo.ProGet.Feeds.StandardPackageFeed`3.AddPackageAsync(Stream stream, InstallPackageOptions options, PackageInstallContext context, Nullable`1 publishDate, Boolean listed, CancellationToken cancellationToken) in C:\Users\builds\AppData\Local\Temp\InedoAgent\BuildMaster\192.168.44.60\Temp\_E519417\Src\ProGetCoreEx\Feeds\StandardPackageFeed.cs:line 172
   at Inedo.ProGet.Feeds.StandardPackageFeed`3.AddPackageAsync(Stream stream, InstallPackageOptions options, PackageInstallContext context, Nullable`1 publishDate, Boolean listed, CancellationToken cancellationToken) in C:\Users\builds\AppData\Local\Temp\InedoAgent\BuildMaster\192.168.44.60\Temp\_E519417\Src\ProGetCoreEx\Feeds\StandardPackageFeed.cs:line 244
   at Inedo.ProGet.WebApplication.FeedEndpoints.Maven.SubHandlers.ArtifactUploadHandler.ProcessRequestAsync(AhHttpContext context, WebApiContext apiContext, Maven2Feed feed, ParsedMavenPath parsedUrl) in C:\Users\builds\AppData\Local\Temp\InedoAgent\BuildMaster\192.168.44.60\Temp\_E519417\Src\ProGet.WebApplication\FeedEndpoints\Maven\SubHandlers\ArtifactUploadHandler.cs:line 22
   at Inedo.ProGet.WebApplication.FeedEndpoints.Maven.MavenFeedHandler.ProcessRequestAsync(AhHttpContext context, WebApiContext apiContext, Feed feed, String relativeUrl) in C:\Users\builds\AppData\Local\Temp\InedoAgent\BuildMaster\192.168.44.60\Temp\_E519417\Src\ProGet.WebApplication\FeedEndpoints\Maven\MavenFeedHandler.cs:line 86
   at Inedo.ProGet.WebApplication.FeedEndpoints.FeedEndpointHandler.FeedRequestHandler.ProcessRequestAsync(AhHttpContext context) in C:\Users\builds\AppData\Local\Temp\InedoAgent\BuildMaster\192.168.44.60\Temp\_E519417\Src\ProGet.WebApplication\FeedEndpoints\FeedEndpointHandler.cs:line 191

::Web Error on 01/13/2025 11:12:24::

[atripp]

hi @hammel_7023 ,

Thanks for letting us know, you are correct... this is indeed a regression from PG-2859.

What's happening is the upload stream is getting prematurely closed during the POM validation logic, which is what's causing this error to occur.

I've just patched it now via PG-2868, and it'll get in the next maintenance release.

Cheers,
Alana