Encode URI incorrectly cause GCR connector not working

[PMExtra]

Re: ProGet Docker Connector to gcr.io not working

I met the same problem. After analysed the captured traffic, I found that ProGet encoded the URI incorrectly.

The colon (:) does not need to be encoded in URI (ref https://stackoverflow.com/questions/2053132/is-a-colon-safe-for-friendly-url-use).

GCR needs the original colon rather than %3A, but ProGet encoded it. So we got 404 response from GCR.

Example:

This is a good request:
https://gcr.io/v2/kaniko-project/executor/manifests/sha256:034f15e6fe235490e64a4173d02d0a41f61382450c314fffed9b8ca96dff66b2

But ProGet encoded the colon:
https://gcr.io/v2/kaniko-project/executor/manifests/sha256%3A034f15e6fe235490e64a4173d02d0a41f61382450c314fffed9b8ca96dff66b2

[atripp]

Hi @PMExtra ,

Thanks for the details on this, very helpful :)

We actually recently discovered this too (though a different underlying problem) - it was should be addressed in 2022.27 via PG-2321.

Can you try that and see if it helps? We can investigate further if not.

Cheers,
Alana

[PMExtra]

The problem still exists in version 23.0.7

[atripp]

Hi @PMExtra ,

Looks like this didn't make it to the 2023 codebase; I've just merged it in via PG-2388 (shipping this friday in ProGet 2023.8).

Cheers,
Alana