Inedo Community Forums Forums
    • Recent
    • Tags
    • Popular
    • Login

    Welcome to the Inedo Forums! Check out the Forums Guide for help getting started.

    If you are experiencing any issues with the forum software, please visit the Contact Form on our website and let us know!

    GetPackagesById() is over zelous with casing

    Scheduled Pinned Locked Moved Support
    progetnuget
    3 Posts 1 Posters 28 Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • ? This user is from outside of this forum
      Guest
      last edited by

      Hi,
      After being sure that I found a bug with the new dotnet tool install -g flow, with the help of Microsoft employees, I ended up realizing that ProGet was being overzelous with respect to the case sensitivity when searching / serving packages.

      According to the official nuget implementation, package Ids are case INsensitive:
      https://github.com/NuGet/NuGet.Client/blob/1a1c474aab5c1e851b416c583ca4c6d727bd94e3/src/NuGet.Core/NuGet.Packaging.Core/comparers/PackageIdentityComparer.cs#L70

      When I push into proget a package with mixed casing, and later run a "dotnet tool install -g" command, the dotnet tool client searches for lower case package-id, and proget fails to find such a package since it is doing a case sensitive search.

      After renaming my package to all lower case, everything seems to work again.

      I hope I've managed to explain myself properly.

      It seems like proget SHOULD switch to case insensitive search in order to be compatible with the nuget protocol "spec" and dotnet tool install -g, more specifically.

      Hope you will consider changing the default behavior for ProGet!

      Product: ProGet
      Version: 5.1.8

      1 Reply Last reply Reply Quote 0
      • ? This user is from outside of this forum
        Guest
        last edited by

        Hi Dan,

        All of our package id's are indexed case insensitive as well. We'll do some quick testing to try to reproduce this and then follow up with you.

        Thanks!

        1 Reply Last reply Reply Quote 0
        • ? This user is from outside of this forum
          Guest
          last edited by

          We can't reproduce this - in all cases we've tried the casing of supplied package ID's does not matter in requests to ProGet.

          If you capture the failing requests using Fiddler and attach them to a ticket, we can hopefully find out why it is not working for you.

          1 Reply Last reply Reply Quote 0

          Hello! It looks like you're interested in this conversation, but you don't have an account yet.

          Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.

          With your input, this post could be even better 💗

          Register Login
          • 1 / 1
          • First post
            Last post
          Inedo Website Home • Support Home • Code of Conduct • Forums Guide • Documentation