@sebastian Thank you for your thorough review and thoughts. I've updated the code to address your concerns, I believe. Please review when you have a moment? I'll clean up commit history when things are good to go :)
Welcome to the Inedo Forums! Check out the Forums Guide for help getting started.
If you are experiencing any issues with the forum software, please visit the Contact Form on our website and let us know!
S
shayde
@shayde
0
Reputation
3
Posts
1
Profile views
0
Followers
0
Following
Best posts made by shayde
This user hasn't posted anything yet.
Latest posts made by shayde
-
RE: pgscan: lockfileVersion 3 for npm dependencies not supported
-
RE: pgscan: lockfileVersion 3 for npm dependencies not supported
I have a PR open on GitHub here that is working locally targeting a lockfileVersion 2 and a lockfileVersion 3. I'm sure it could use some improvements if anyone has the chance to review.
-
RE: pgscan: lockfileVersion 3 for npm dependencies not supported
Per https://github.com/Inedo/pgscan/issues/34, I am open to contributing a fix for this to support lockfileversion 3, if I can get confirmation from @atripp and co that such a contribution would be acceptable / worthwhile. You okay if I spend an afternoon taking a crack at this?